Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support table navigation for WPF list item DataItem objects #12928

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

None

Steps to reproduce the issue

  1. Open PowerShell
  2. Type Get-Process | Out-GridView
  3. Observe that table navigation doesn't work on the several entries in the grid.

Description of how this pull request fixes the issue:

This pr adds the RowWithFakeNavigation on these objects, thereby automatically exposing the ability to table nav through the grid, including reading of column headers.

Testing strategy:

Tested in both PowerShell 5.1 and PowerShell Core 7.1

Known issues with pull request:

This change might hit untested controls. Note that the logic in RowWithFakeNavigation continuously checks child count, so I think it's pretty safe to add. It is also added to icons on the desktop, for example.

Change log entries:

New features

  • Table navigation is now supported in grid controls created using the Out-GridView cmdlet in PowerShell.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@LeonarddeR LeonarddeR requested a review from a team as a code owner October 13, 2021 07:33
@LeonarddeR LeonarddeR requested a review from seanbudd October 13, 2021 07:33
@seanbudd seanbudd merged commit a2b2e3d into nvaccess:master Oct 14, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants